Skip to content

tests: Default integration test threads to 1 #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alicefr merged 1 commit into from
Jan 12, 2026
Merged

tests: Default integration test threads to 1 #144

alicefr merged 1 commit into from
Jan 12, 2026

Conversation

@Jakob-Naucke
Copy link
Contributor

@Jakob-Naucke Jakob-Naucke commented Jan 8, 2026

Let test executors decide how many threads they want on the (very memory-intensive) integration tests. Some CI runners, such as openshift-ci, do not have the resources to run 3 at a time.

@alicefr or, if you prefer, something like

# If $THREADS is set, multi-thread integration tests with $THREADS but at most 3.
# Otherwise, do not multi-thread integration tests.
THREADS ?= 1
INTEGRATION_TEST_THREADS = $$(( $(THREADS) > 3 ? 3 : $(THREADS) ))

@yalzhang idk if we want to just merge this or you want to patch it into openshift/release#73211 for testing (but then we should remove it before merging)

@Jakob-Naucke
tests: Default integration test threads to 1
4dca750 
Let test executors decide how many threads they want on the (very
memory-intensive) integration tests. Some CI runners, such as
openshift-ci, do not have the resources to run 3 at a time.

Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Jan 8, 2026

@Jakob-Naucke: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/operator-lifecycle-verify 4dca750 link true /test operator-lifecycle-verify
ci/prow/infra-provision-verify 4dca750 link true /test infra-provision-verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Jakob-Naucke
Copy link
Contributor Author

Jakob-Naucke commented Jan 8, 2026

The test over at openshift/release#73211 passed with this patch applied. @yalzhang lmk what a smart order to merge the PRs would be.

@openshift-ci openshift-ci bot added the lgtm label Jan 12, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 12, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alicefr, Jakob-Naucke

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alicefr
Copy link
Contributor

alicefr commented Jan 12, 2026

This looks great!

@alicefr alicefr merged commit 77ef33b into trusted-execution-clusters:main Jan 12, 2026
8 of 10 checks passed
@alicefr
Copy link
Contributor

alicefr commented Jan 12, 2026 •
edited
Loading

Maybe we can enable and use KSM to run multiple VMs in parallel for the future. It might help reducing the memory footprint of the CI

@Jakob-Naucke Jakob-Naucke deleted the optional-parallel-integration branch January 12, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alicefr alicefr alicefr approved these changes

Assignees

@alicefr alicefr

Labels

lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jakob-Naucke @alicefr